Add GO111MODULE=off to build.sh, use Golang 1.16 #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvaillancourt
changed the title
gtowey
approved these changes
May 24, 2021
staktrace
added a commit
to staktrace/gh-ost
that referenced
this pull request
May 30, 2022
PR github#966 updated the PREFERRED_GO_VERSION from go1.14.7 to go1.16.4 but didn't updated the corresponding binary checksums. The checksums can be found at https://go.dev/dl/
This was referenced May 30, 2022
staktrace
added a commit
to staktrace/gh-ost
that referenced
this pull request
May 30, 2022
PR github#966 updated the PREFERRED_GO_VERSION from go1.14.7 to go1.16.4 but didn't updated the corresponding binary checksums. The checksums can be found at https://go.dev/dl/
staktrace
added a commit
to staktrace/gh-ost
that referenced
this pull request
May 30, 2022
PR github#966 updated the PREFERRED_GO_VERSION from go1.14.7 to go1.16.4 but didn't update the corresponding binary checksums. The checksums can be found at https://go.dev/dl/ Additionally, the package file inside has changed and requires updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #933
Description
This PR adds
GO111MODULE=offto thego buildline of various build scripts/configs so that builds succeed on Golang 1.16This is a temporary solution until #935 is merged, in which case the
GO111MODULEoverride can be removed. Currently this PR is blocked by some testing failuresResolves #933
script/cibuildreturns with no formatting errors, build errors or unit test errors.